Hotfix document search http #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2020 09:11
scottinet
approved these changes
Mar 30, 2020
rolljee
approved these changes
Mar 30, 2020
rolljee
reviewed
Mar 30, 2020
| routes[controller][action] = getCorrectRoute(http); | ||
| } | ||
| else if (http && http.length > 1) { | ||
| // We need this ugly fix because the document:search route can also |
There was a problem hiding this comment.
Is it missing one word to fully understand those 2 first comment ?
Codecov Report
@@ Coverage Diff @@
## 7-dev #498 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 32 32
Lines 1308 1309 +1
=======================================
+ Hits 1253 1254 +1
Misses 55 55
Continue to review full report at Codecov.
|
Merged
Aschen
added a commit
that referenced
this pull request
Mar 31, 2020
# [7.1.2](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.1.2) (2020-03-31) #### Bug fixes - [ [#498](#498) ] Hotfix document search http ([Aschen](https://github.com/Aschen)) #### Enhancements - [ [#496](#496) ] Exposes SearchResult classes ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When we have multiple choose for a route, we choose the shortest or the GET route.
With
document:createwe have the choice between those 2 routes:The problem is that after even if we want to change the verb by using
options.verb, the URL is not the good one andGET /:index/:collectioncorrespond to thecollection:createmethod.So this PR is just a dirty fix to always use the POST route with
document:search.When we are going to fully support the GET verb with query for
document:search, maybe we can get ride of this.See this failing job on Kuzzle: https://travis-ci.org/github/kuzzleio/kuzzle/jobs/667658863